[JENKINS-37565] Allow specifying custom java.level #11
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
🐝 |
|
@reviewbybees done |
|
This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging. |
|
@oleg-nenashev Should this have a corresponding change in the plugin archetype? |
| @@ -612,6 +614,12 @@ | |||
| <!-- By default only check remote repositories once per week --> | |||
| <maven.repository.update.freqency>interval:10080</maven.repository.update.freqency> | |||
|
|
|||
| <!-- Starting from Jenkins 1.625.x Jenkins supports Java 7 only, hence we may want to bump the dependency in components --> | |||
| <java.level>6</java.level> | |||
There was a problem hiding this comment.
🐜 I would just default it to 7 at this point.
There was a problem hiding this comment.
Then we need to bump a major version number. Otherwise people may upgrade and get side effects in their projects.
There was a problem hiding this comment.
Any POM upgrade can cause side effects in projects. There is no notion of automatically compatible upgrades of POMs that I know of.
|
🐝
I think you mean |
|
plugin-pom 2.x already has such code snippet (with default java.level == 7), so it should be fine |
Sorry, I missed that |
It is required for JENKINS-37565
I have not touched the default version just in case other components still need Java 6.
@reviewbybees @jenkinsci/code-reviewers